Release v5.2.0 - #33
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every
Textis now centred on its position, whichever constructor built it andwhichever style it is in — the way a sprite put at the same place is, and the way
everything in a Scratch project is placed. Only
new Text()used to be centred:new Text(words, x, y, width)and the framed styles sat to the left of theirposition instead, so the same words moved sideways depending on how they had been
created, and the browser port drew them somewhere else again.
The texts the library builds for itself keep the edge they are anchored by and
now say so where they are built: the stage's
display()andask()bands reachfrom side to side, and a sprite's speech bubble hangs off the tail in its bottom
left corner.
Add
setAlign(TextAlign.LEFT)to text that was relying on starting at itsposition rather than being centred on it.
The box
Stage.ask()puts the question in now reaches from one side of thestage to the other and squares off the two corners sitting on the bottom edge,
the way the band
display()writes into already did. It used to be only as wideas the longest line it happened to hold, and it curved away at the bottom where
the stage ends.
Fix the
Stage.ask()Javadoc, which said the question box appears at the top ofthe stage. It appears at the bottom, where Scratch puts it too.